Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the construction of Delay using the clock::v2 API #803

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Allow the construction of Delay using the clock::v2 API #803

merged 4 commits into from
Jan 6, 2025

Conversation

rnd-ash
Copy link
Contributor

@rnd-ash rnd-ash commented Dec 10, 2024

This PR introduces Delay::new_with_source function, which is compatible with the V2 clocking API, allowing the usage of Delay after calling clock_system_at_reset (Which is required for MCAN)

Example usage:

let (pclk_can0, gclk0) = pclk::Pclk::enable(tokens.pclks.can0, clocks.gclk0);
let (mut delay, gclk0) = Delay::new_with_source(cpu_core.SYST, gclk0);

@kyp44 kyp44 mentioned this pull request Dec 11, 2024
Open
@jbeaurivage
Copy link
Contributor

jbeaurivage commented Jan 5, 2025 •
edited
Loading

@rnd-ash, is there a reason why we'd want to restrict the clock source to GCLK0 only? According to the datasheet, the CAN peripheral should work with any GCLK.

Nevermind, somehow I missed the fact that Delay used the systick which is tied to the CPU clock. If you fix the CI errors I'll be happy to merge this.

@rnd-ash
Copy link
Contributor Author

rnd-ash commented Jan 6, 2025

ok @jbeaurivage all tests pass now

@jbeaurivage jbeaurivage merged commit b0e341e into atsamd-rs:master Jan 6, 2025
108 checks passed
This was referenced Jan 6, 2025
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnd-ash @jbeaurivage